Two tests Ported from the LLVM Project to Translator#3342
Two tests Ported from the LLVM Project to Translator#3342MrSidims merged 1 commit intoKhronosGroup:mainfrom
Conversation
SubashBoopathi
force-pushed
the
port_test3
branch
from
f64377d to
dcc5c5b
Compare
| @@ -0,0 +1,165 @@ | |||
| ; RUN: llvm-as %s -o %t.bc | |||
There was a problem hiding this comment.
I do remember this test was failing, when I first saw the PR. What has changed since then? Force-pushes are making it impossible for me to find out.
There was a problem hiding this comment.
I updated the test by removing some extra CHECK directives that are irrelevant and now passes all RUN commands. I’ll avoid force-pushes or add clearer notes next time to make changes easier to follow.
There was a problem hiding this comment.
Do I understand correctly, that reverse translation was failing? I'm not saying, that you should fix this, but I'm trying to understand, whether we have a bug anywhere and we just had an opportunity to catch and file it.
There was a problem hiding this comment.
@MrSidims The issue wasn’t related to reverse translation. Initially, I planned to include checks for some additional intrinsics, but since those intrinsics already had tests elsewhere, I removed their checks from the test file. Unfortunately, my initial removal wasn’t complete, which caused the failures you saw earlier. The fix was simply cleaning up those leftover, unnecessary CHECK directives of the removed intrinsics tests.
MrSidims
left a comment
MrSidims
left a comment
There was a problem hiding this comment.
Fine with me, @SubashBoopathi if it's possible, could you please check git reflog to get the removed CHECKs and submitting them as an issue to the translator, so we could verify, that them were wrong or there is something to fix in the translator?
3 participants
Ported two tests from the LLVM project to the SPIRV-LLVM-Translator: icmp.ll validates integer comparison instructions for scalar and vector types, and fp-vector-intrinsics.ll verifies floating-point vector intrinsics, ensuring accurate SPIR-V translation.